Skip to content

Add nightly builds #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add nightly builds #27

wants to merge 1 commit into from

Conversation

kpalang
Copy link
Contributor

@kpalang kpalang commented Apr 8, 2025

Add nightly builds of OIE

@kpalang
#3 #11 Add nightly builds
0b64658 
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
@kpalang kpalang requested a review from jonbartels April 8, 2025 14:34
@jonbartels
Copy link
Contributor

The scope of #3 is to make tarballs and zips

The scope of #11 is java support.

Neither requires nightly builds.

Why not run builds on every merge to main. That way downloadable artifacts for the latest changes exist. Daily builds could add noise if we are not committing daily. Daily builds could miss changes if the team has a busy day.

tonygermano
tonygermano reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@tonygermano tonygermano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with @jonbartels that this probably isn't necessary since the automated builds were already running on every PR and push to main. I think the exception would be if the nightly tarballs could be published to a static link, so the url for the latest nightly never changed. Probably not worth the time to work on that at the moment since people can still grab the build with the latest changes from GH if they want it.

@kpalang
Copy link
Contributor Author

kpalang commented Apr 9, 2025

Good points. Closing this PR.

@kpalang kpalang closed this Apr 9, 2025
@tonygermano tonygermano deleted the feature/nightly-builds branch April 15, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonygermano tonygermano tonygermano left review comments

@jonbartels jonbartels Awaiting requested review from jonbartels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpalang @jonbartels @tonygermano